-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sendRawTranscationConditional op-e2e test #11671
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hamdiallam and the rest of your teammates on Graphite |
c56b5f9
to
740e21b
Compare
740e21b
to
753eacf
Compare
95dde60
to
26f631c
Compare
753eacf
to
3ec7222
Compare
26f631c
to
1691a15
Compare
3ec7222
to
48486f0
Compare
48486f0
to
c3671c9
Compare
c3671c9
to
a8790fd
Compare
Semgrep found 1 Prefer |
@protolambda @tynes soft bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given there are unit tests for the validity conditions being applied themselves, this covers sending and forwarding thru the RPC
Requires
Adds an op-e2e test for the SendRawTransactionConditional endpoint.
Monorepo was fitting as we dont have e2e tests for feature in op-geth and the txproxy is a supplemental/external service to this endpoint tested separately for what it does. The monorepo e2e tests op-geth pathways hence placing it here
tests pass locally (just waiting for a tagged release of op-geth to update the monorepo with)